Remove gas accounting from AotContractExecutor #938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edg-l
requested review from
igaray,
azteca1998,
jrchatruc,
entropidelic,
fmoletta,
Oppen and
pefontana
as code owners
edg-l
changed the title
|
✅ Code is now correctly formatted. |
Benchmarking resultsBenchmark for program
|
| Command | Mean [s] | Min [s] | Max [s] | Relative |
|---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
11.190 ± 0.407 | 10.724 | 11.668 | 8.30 ± 0.30 |
cairo-native (embedded AOT) |
3.501 ± 0.109 | 3.390 | 3.686 | 2.60 ± 0.08 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
3.252 ± 0.038 | 3.202 | 3.333 | 2.41 ± 0.03 |
cairo-native (standalone AOT with -march=native) |
1.348 ± 0.004 | 1.346 | 1.358 | 1.00 |
Benchmark for program fib_2M
Open benchmarks
| Command | Mean [s] | Min [s] | Max [s] | Relative |
|---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
10.930 ± 0.299 | 10.649 | 11.456 | 140.17 ± 3.86 |
cairo-native (embedded AOT) |
2.969 ± 0.023 | 2.942 | 3.009 | 38.08 ± 0.31 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
2.770 ± 0.019 | 2.745 | 2.812 | 35.53 ± 0.26 |
cairo-native (standalone AOT with -march=native) |
0.078 ± 0.000 | 0.078 | 0.078 | 1.00 |
Benchmark for program logistic_map
Open benchmarks
| Command | Mean [s] | Min [s] | Max [s] | Relative |
|---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
4.211 ± 0.032 | 4.147 | 4.268 | 17.34 ± 0.20 |
cairo-native (embedded AOT) |
3.075 ± 0.026 | 3.043 | 3.121 | 12.66 ± 0.16 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
3.029 ± 0.027 | 2.984 | 3.055 | 12.47 ± 0.16 |
cairo-native (standalone AOT with -march=native) |
0.243 ± 0.002 | 0.242 | 0.250 | 1.00 |
|
Benchmark results Main vs HEAD.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #938 +/- ##
==========================================
- Coverage 82.63% 82.55% -0.08%
==========================================
Files 117 117
Lines 33505 33505
==========================================
- Hits 27687 27661 -26
- Misses 5818 5844 +26 ☔ View full report in Codecov by Sentry. |
azteca1998
previously approved these changes
Nov 25, 2024
gabrielbosio
previously approved these changes
Nov 25, 2024
FrancoGiachetta
previously approved these changes
Nov 25, 2024
…costs on AotContractExecutor
edg-l
dismissed stale reviews from FrancoGiachetta, gabrielbosio, and azteca1998
via
2ec6daa
azteca1998
approved these changes
Nov 26, 2024
Merged
FrancoGiachetta
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the initial gas cost calculations and substractions, the caller will handle it.
Checklist